diff options
author | Carsten Schoenert <c.schoenert@t-online.de> | 2023-08-28 13:44:11 +0530 |
---|---|---|
committer | Thomas Lange <lange@debian.org> | 2023-12-02 16:47:00 +0100 |
commit | 07d2ea17183f98bef8e691916166cf5e887debba (patch) | |
tree | c5c7989099b2bf9bf6c1cdd55fb4bf3461e616ef /english/security/oval | |
parent | 6073fd723a6f0e38b77c6f47eaabd911057dc9fb (diff) |
generator.py: Unify comments style
Diffstat (limited to 'english/security/oval')
-rw-r--r-- | english/security/oval/oval/definition/generator.py | 28 |
1 files changed, 14 insertions, 14 deletions
diff --git a/english/security/oval/oval/definition/generator.py b/english/security/oval/oval/definition/generator.py index 4103a5ada96..62b613612fc 100644 --- a/english/security/oval/oval/definition/generator.py +++ b/english/security/oval/oval/definition/generator.py @@ -71,7 +71,7 @@ statesCurId = 1 releaseArchHash = {"2.0": 2, "2.1": 4, "2.2": 6, "3.0": 11, "3.1": 12, "4.0": 11, "5.0": 12, "6.0": 11} testsHash = {"arch": {}, "release": {}, "obj": {}, "fileSte": {}, "unameSte": {}, "dpkgSte": {}} -#We need more info about alpha, arm, hppa, bmips, lmips +# We need more info about alpha, arm, hppa, bmips, lmips unameArchTable = {'i386': 'i686', 'amd64': 'x86-64', 'ia64': 'ia64', 'powerpc': 'ppc', 's390': 's390x', 'm86k': 'm86k'} @@ -174,7 +174,7 @@ def __createOVALState(value, operation="less than"): Use state hash for optimization of resulted XML """ - #TODO: Add arch state generation + # TODO: Add arch state generation if operation not in testsHash["dpkgSte"] or value not in testsHash["dpkgSte"][operation]: stateId = __getNewId("state") @@ -203,7 +203,7 @@ def __createOVALUnameState(field, value, operation="equals"): except KeyError: pass - #TODO: Add arch state generation + # TODO: Add arch state generation if operation not in testsHash["unameSte"] or value not in testsHash["unameSte"][operation]: stateId = __getNewId("state") @@ -225,7 +225,7 @@ def __createOVALTextfilecontentState(value, operation="equals"): Use state hash for optimization of resulted XML """ - #TODO: Add arch state generation + # TODO: Add arch state generation if operation not in testsHash["fileSte"] or value not in testsHash["fileSte"][operation]: stateId = __getNewId("state") @@ -337,7 +337,7 @@ def createPlatformDefinition(release, data, cve): return Generated XML fragment """ - #Raise exception if we receive too small data + # Raise exception if we receive too small data if len(data) == 0: logging.warning("CVE %s: Information of affected platforms is not available." % cve) @@ -351,7 +351,7 @@ def createPlatformDefinition(release, data, cve): archIndepCriteria = __createXMLElement("criteria", attrs={"comment": "Architecture independent section", "operator": "AND"}) archIndepCriteria.append(__createXMLElement("criterion", attrs={"test_ref": __createTest("arch", "all"), "comment": "all architecture"})) - #Build packages section only if we have more then one package + # Build packages section only if we have more then one package if len(data["all"]) > 1: packageCriteria = __createXMLElement("criteria", attrs={"comment": "Packages section", "operator": "OR"}) archIndepCriteria.append(packageCriteria) @@ -457,7 +457,7 @@ def createDefinition(cve, oval): logging.warning("CVE %s: Secrefs information missed." % cve) oval["secrefs"] = "" - ### Definition block: Metadata, Notes, Criteria + # Definition block: Metadata, Notes, Criteria ovalId = getOvalId(cve) if oval['title'].startswith('CVE'): definition = __createXMLElement("definition", attrs={"id": "oval:org.debian:def:%s" % ovalId, @@ -466,18 +466,18 @@ def createDefinition(cve, oval): definition = __createXMLElement("definition", attrs={"id": "oval:org.debian:def:%s" % ovalId, "version": "1", "class": "patch"}) - ### Definition : Metadata : title, affected, reference, description ### + # Definition : Metadata : title, affected, reference, description metadata = __createXMLElement("metadata") metadata.append(__createXMLElement("title", oval["title"])) - ### Definition : Metadata : Affected : platform, product ### + # Definition : Metadata : Affected : platform, product affected = __createXMLElement("affected", attrs={"family": "unix"}) for platform in oval["release"]: affected.append(__createXMLElement("platform", "Debian GNU/Linux %s" % platform)) affected.append(__createXMLElement("product", oval.get("packages"))) metadata.append(affected) - ### Definition : Metadata : Affected : END ### + # Definition : Metadata : Affected : END refpatern = re.compile(r'((CVE|CAN)-[\d-]+)') for ref in oval.get("secrefs"): @@ -486,7 +486,7 @@ def createDefinition(cve, oval): (ref_id, source) = result.groups() metadata.append(__createXMLElement("reference", attrs={"source": source, "ref_id": ref_id, "ref_url": "https://cve.mitre.org/cgi-bin/cvename.cgi?name=%s" % ref_id})) - #TODO: move this info to other place + # TODO: move this info to other place metadata.append(__createXMLElement("description", oval["description"])) debianMetadata = __createXMLElement("debian") dsa = oval.get("dsa", None) @@ -499,9 +499,9 @@ def createDefinition(cve, oval): metadata.append(debianMetadata) definition.append(metadata) - ### Definition : Criteria ### + # Definition : Criteria if len(oval["release"]) > 1: - #f we have more than one release - generate additional criteria section + # If we have more than one release - generate additional criteria section platformCriteria = __createXMLElement("criteria", attrs={"comment": "Platform section", "operator": "OR"}) definition.append(platformCriteria) else: @@ -511,7 +511,7 @@ def createDefinition(cve, oval): data = oval["release"][platform] platformCriteria.append(createPlatformDefinition(platform, data, cve)) - ### Definition : Criteria END ### + # Definition : Criteria END return definition |