From 3902f3b980c0e2a885b965b4f2503244c3e68782 Mon Sep 17 00:00:00 2001 From: kongr45gpen Date: Fri, 16 Sep 2016 14:14:14 +0300 Subject: Improve HTTP response --- local/handler/GithubHandler.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'local') diff --git a/local/handler/GithubHandler.py b/local/handler/GithubHandler.py index 909484e..b791298 100644 --- a/local/handler/GithubHandler.py +++ b/local/handler/GithubHandler.py @@ -95,22 +95,24 @@ class GithubHandler(BaseHTTPServer.BaseHTTPRequestHandler): try: s.send_response(200) - s.send_header('Content-type', 'text/html') + s.send_header('Content-type', 'text/plain') s.end_headers() - s.wfile.write("Thanks, you're awesome.\n") + s.wfile.write("Thanks!\n") s.wfile.write(s.path.split('/')) + s.wfile.write("\n") except socket.error: pass if requireCode and receivedcode != configValue('passcode'): # The password is wrong - s.wfile.write("The password is wrong") + s.wfile.write("The password is wrong\n") return + # Handle Github secrets secret = getChannelSecret(channel) if secret is not None: if not 'X-Hub-Signature' in s.headers: - s.wfile.write("This channel requires a secret") + s.wfile.write("This channel requires a secret\n") return digest = "sha1=%s" % (hmac.new(secret, payload, hashlib.sha1).hexdigest(),) @@ -120,7 +122,7 @@ class GithubHandler(BaseHTTPServer.BaseHTTPRequestHandler): log.debug("provided digest: %s", provided) if not secureCompare(digest, provided): - s.wfile.write("Invalid secret key") + s.wfile.write("Invalid secret key\n") return brackets = parseBrackets(configValue('brackets')) -- cgit v1.2.3