aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJason Oster <parasytic@users.sourceforge.net>2010-04-19 14:47:56 +0000
committerJason Oster <parasytic@users.sourceforge.net>2010-04-19 14:47:56 +0000
commitcf1573b46f7927e4c0963a1b4f6f5dac64dec10c (patch)
tree5de7d421705208ada0428c65ca9bdde1c5015bb1
parent8ed31f03bc6e1ea2c1b5593bee9b8daac5e7b630 (diff)
downloadphpicalendar-cf1573b46f7927e4c0963a1b4f6f5dac64dec10c.tar.gz
phpicalendar-cf1573b46f7927e4c0963a1b4f6f5dac64dec10c.tar.bz2
phpicalendar-cf1573b46f7927e4c0963a1b4f6f5dac64dec10c.zip
Simplify save_parsed_cals and correct even more filename bugs
-rw-r--r--functions/ical_parser.php132
1 files changed, 51 insertions, 81 deletions
diff --git a/functions/ical_parser.php b/functions/ical_parser.php
index 7572442..19027a0 100644
--- a/functions/ical_parser.php
+++ b/functions/ical_parser.php
@@ -11,97 +11,68 @@ include_once(BASE.'functions/parse/recur_functions.php');
$realcal_mtime = time();
$parse_file = true;
if ($phpiCal_config->save_parsed_cals == 'yes') {
- if (count($cal_filelist) == count($all_calendars_combined)) {
- // This is a special case for "all calendars combined"
- $parsedcal = $phpiCal_config->tmp_dir.'/parsedcal-'.urlencode($cpath.'::'.$phpiCal_config->ALL_CALENDARS_COMBINED).'-'.$this_year;
- if (file_exists($parsedcal)) {
- $fd = fopen($parsedcal, 'r');
- $contents = fread($fd, filesize($parsedcal));
- fclose($fd);
- $master_array = unserialize($contents);
- $y=0;
- // Check the calendars' last-modified time to determine if any need to be re-parsed
- if (sizeof($master_array['-4']) == (sizeof($cal_filelist))) {
- foreach ($master_array['-4'] as $temp_array) {
- $mtime = $temp_array['mtime'];
- $fname = $temp_array['filename'];
- $wcalc = $temp_array['webcal'];
+ sort($cal_filelist);
+ $filename = sha1(implode(',', $cal_filelist));
+ $parsedcal = "{$phpiCal_config->tmp_dir}/parsedcal-{$filename}-{$this_year}";
+ if (file_exists($parsedcal)) {
+ $fd = fopen($parsedcal, 'r');
+ $contents = fread($fd, filesize($parsedcal));
+ fclose($fd);
+ $master_array = unserialize($contents);
+ $y=0;
+ // Check the calendars' last-modified time to determine if any need to be re-parsed
+ if (count($master_array['-4']) == count($cal_filelist)) {
+ foreach ($master_array['-4'] as $temp_array) {
+ $mtime = $temp_array['mtime'];
+ $fname = $temp_array['filename'];
+ $wcalc = $temp_array['webcal'];
- if ($wcalc == 'no') {
- /*
- * Getting local file mtime is "fairly cheap"
- * (disk I/O is expensive, but *much* cheaper than going to the network for remote files)
- */
- $realcal_mtime = filemtime($fname);
- }
- else if ((time() - $mtime) >= $phpiCal_config->webcal_hours * 60 * 60) {
- /*
- * We limit remote file mtime checks based on the magic webcal_hours config variable
- * This allows highly volatile web calendars to be cached for a period of time before
- * downloading them again
- */
- $realcal_mtime = remote_filemtime($fname);
- }
- else {
- // This is our fallback, for the case where webcal_hours is taking effect
- $realcal_mtime = $mtime;
- }
-
- // If this calendar is up-to-date, the $y magic number will be incremented...
- if ($mtime >= $realcal_mtime) {
- $y++;
- }
+ if ($wcalc == 'no') {
+ /*
+ * Getting local file mtime is "fairly cheap"
+ * (disk I/O is expensive, but *much* cheaper than going to the network for remote files)
+ */
+ $realcal_mtime = filemtime($fname);
}
-
- foreach ($master_array['-3'] as $temp_array) {
- if (isset($temp_array) && $temp_array !='') $caldisplaynames[] = $temp_array;
+ else if ((time() - $mtime) >= $phpiCal_config->webcal_hours * 60 * 60) {
+ /*
+ * We limit remote file mtime checks based on the magic webcal_hours config variable
+ * This allows highly volatile web calendars to be cached for a period of time before
+ * downloading them again
+ */
+ $realcal_mtime = remote_filemtime($fname);
}
-
- // And the $y magic number is used here to determine if all calendars are up-to-date
- if ($y == sizeof($cal_filelist)) {
- if ($master_array['-1'] == 'valid cal file') {
- // At this point, all calendars are up-to-date, so we can simply used the pre-parsed data
- $parse_file = false;
- $calendar_name = $master_array['calendar_name'];
- if (isset($master_array['calendar_tz']))
- $calendar_tz = $master_array['calendar_tz'];
- }
+ else {
+ // This is our fallback, for the case where webcal_hours is taking effect
+ $realcal_mtime = $mtime;
+ }
+
+ // If this calendar is up-to-date, the $y magic number will be incremented...
+ if ($mtime >= $realcal_mtime) {
+ $y++;
}
}
- }
- if ($parse_file == true) {
- // We need to re-parse at least one calendar, so unset master_array
- unset($master_array);
- }
- } else {
- foreach ($cal_filelist as $filename) {
- $parsedcal = $phpiCal_config->tmp_dir.'/parsedcal-'.urlencode($cpath.'::'.$filename).'-'.$this_year;
- if (file_exists($parsedcal)) {
- $parsedcal_mtime = filemtime($parsedcal);
- if (((time() - $parsedcal_mtime) >= $phpiCal_config->webcal_hours * 60 * 60) &&
- (substr($filename, 0, 7) == 'http://' || substr($filename, 0, 8) == 'https://' || substr($filename, 0, 9) == 'webcal://')) {
- $realcal_mtime = remote_filemtime($filename);
- }
- else {
- $realcal_mtime = $parsedcal_mtime;
- }
+ foreach ($master_array['-3'] as $temp_array) {
+ if (isset($temp_array) && $temp_array !='') $caldisplaynames[] = $temp_array;
+ }
- if ($parsedcal_mtime >= $realcal_mtime) {
- $fd = fopen($parsedcal, 'r');
- $contents = fread($fd, filesize($parsedcal));
- fclose($fd);
- $master_array = unserialize($contents);
- if ($master_array['-1'] == 'valid cal file') {
- $parse_file = false;
- $calendar_name = $master_array['calendar_name'];
- if (isset($master_array['calendar_tz']))
- $calendar_tz = $master_array['calendar_tz'];
- }
+ // And the $y magic number is used here to determine if all calendars are up-to-date
+ if ($y == count($cal_filelist)) {
+ if ($master_array['-1'] == 'valid cal file') {
+ // At this point, all calendars are up-to-date, so we can simply used the pre-parsed data
+ $parse_file = false;
+ $calendar_name = $master_array['calendar_name'];
+ if (isset($master_array['calendar_tz']))
+ $calendar_tz = $master_array['calendar_tz'];
}
}
}
}
+ if ($parse_file == true) {
+ // We need to re-parse at least one calendar, so unset master_array
+ unset($master_array);
+ }
}
if ($parse_file) {
@@ -601,7 +572,6 @@ if ($parse_file) {
if ($fd == FALSE) exit(error($lang['l_error_cache'], $filename));
@fwrite($fd, $write_me);
@fclose($fd);
- @touch($parsedcal, $realcal_mtime);
@chmod($parsedcal, 0600); // 0640
}
}

© 2014-2024 Faster IT GmbH | imprint | privacy policy